[Fix] Expose disk cache byte/age limits to PINCache initializer #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gumbypp wants to merge 1 commit into pinterest:master from cionicwear:fix_cache_defaults2

gumbypp commented Jan 30, 2025

What this does

Expose disk cache byte/age limits via PINCache initializer. This allows configuration of these PINDiskCache properties when a PINCache wrapper object is initialized to address [Fix] Disk cache always trims cache to default size on creation #312.

Tech debt

N/A

How I tested it

Tested PINCache construction with different byte/age limits settings and verified that self->_ageLimit and self->_byteLimit were properly set in initializeDiskProperties

What it looks like

No UX changes


          [Fix] Expose disk cache byte/age limits to PINCache initializer

6c54454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet