Skip to content

add worker loader to allow worker to be found after bundling #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbrevda wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Open

add worker loader to allow worker to be found after bundling #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73da360
add worker loader to allow worker to be found after bundling
mbrevda May 1, 2026
503e1ba
Update lib/workerLoader.js
mbrevda May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const { version } = require('./package.json')
const { EventEmitter } = require('events')
const { Worker } = require('worker_threads')
const { join } = require('path')
const { pathToFileURL } = require('url')
const { wait } = require('./lib/wait')
const {
Expand All @@ -12,6 +11,7 @@ const {
} = require('./lib/indexes')
const buffer = require('buffer')
const assert = require('assert')
const { getWorkerPath } = require('./lib/workerLoader')

const kImpl = Symbol('kImpl')

Expand Down Expand Up @@ -52,7 +52,7 @@ function createWorker (stream, opts) {
const { filename, workerData } = opts

const bundlerOverrides = '__bundlerPathsOverrides' in globalThis ? globalThis.__bundlerPathsOverrides : {}
const toExecute = bundlerOverrides['thread-stream-worker'] || join(__dirname, 'lib', 'worker.js')
const toExecute = bundlerOverrides['thread-stream-worker'] || getWorkerPath()

const worker = new Worker(toExecute, {
...opts.workerOpts,
Expand Down
12 changes: 12 additions & 0 deletions lib/workerLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict'

const { isMainThread } = require('worker_threads')
Comment thread
mbrevda marked this conversation as resolved.

// Only runs when spawned as a Worker
if (!isMainThread) require('./worker.js')

function getWorkerPath () {
return __filename
Copy link
Copy Markdown
Member

@mcollina mcollina May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a lot of explanation, can you add some comments?

Note that this value will be incorrect if we are not bundling.

Copy link
Copy Markdown
Author

@mbrevda mbrevda May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this value will be incorrect if we are not bundling.

Not sure I follow - wouldn't it return the path of lib/workerLoader.js, which would then require ./worker.js?

Copy link
Copy Markdown
Author

@mbrevda mbrevda May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed you commented here, but still not sure why this would be incorrect when not bundling?

}

module.exports = { getWorkerPath }
Loading