Skip to content

Upgrade jdbc driver to Amazon's Redshift JDBC 4.1 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucagrulla wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade jdbc driver to Amazon's Redshift JDBC 4.1 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f52c4b2
Upgrade jdbc driver to Amazon's Redshift JDBC 4.1
lucagrulla Oct 9, 2015
a620116
fix driver class name + upgrade to latest driver
lucagrulla Dec 30, 2015
db0737c
Fix doc + Driver reference
lucagrulla Dec 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/redshift.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ library(RJDBC)
redshift.driver <- function(postgresql_driver = "default") {
if(postgresql_driver != "default"){
driver.class.path <- postgresql_driver
} else driver.class.path <- system.file("java", "postgresql-8.4-703.jdbc4.jar", package = "redshift")
} else driver.class.path <- system.file("java", "RedshiftJDBC41-1.1.10.1010.jar", package = "redshift")

return(JDBC("org.postgresql.Driver", driver.class.path, identifier.quote="`"))
return(JDBC("com.amazon.redshift.jdbc41.Driver", driver.class.path, identifier.quote="`"))
}

redshift.connect <- function(jdbcUrl, username, password, custom_driver = "default") {
Expand Down
Binary file added inst/java/RedshiftJDBC41-1.1.10.1010.jar
View file
Open in desktop
Binary file not shown.
Binary file removed inst/java/postgresql-8.4-703.jdbc4.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion man/redshift.driver.Rd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Creates the JDBC driver used by RJDBC to connect to Redshift. Doesn't need to be
redshift.driver(custom_driver = "default")
}
\arguments{
\item{custom_driver}{Option to point to a custom PostgreSQL driver JAR. Class name must be "org.postgresql.Driver"}
\item{custom_driver}{Option to point to a custom PostgreSQL driver JAR. Class name must be "com.amazon.redshift.jdbc41.Driver"}
}
\value{
JDBC Driver
Expand Down