Skip to content

Add repo-root favicon.svg so t3 code shows its own icon#3683

Open
t3dotgg wants to merge 1 commit into
mainfrom
t3code/00c9d048-7327-49a6-b478-5b764e5ed094
Open

Add repo-root favicon.svg so t3 code shows its own icon#3683
t3dotgg wants to merge 1 commit into
mainfrom
t3code/00c9d048-7327-49a6-b478-5b764e5ed094

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Jul 3, 2026

Copy link
Copy Markdown
Member

What changed

Copied the prod brand mark (assets/prod/logo.svg, 1 KB) to favicon.svg at the repo root. One new file, no code changes.

Why it should exist

ProjectFaviconResolver checks favicon.svg at the workspace root as its first candidate, but this repo only has favicons nested under apps/*/public — paths the resolver never checks. So when you open the t3code repo in t3 code itself, the sidebar/thread list renders the generic folder fallback instead of the T3 logo. With this file in place, the resolver's first candidate hits and the app shows its own icon.

The SVG was chosen over the .ico variants because it's the smallest asset, scales crisply, and is the prod mark (the "blueprint" icons are dev/nightly branding).

Before / after

Before (fallback) After
generic folder glyph from FALLBACK_PROJECT_FAVICON_SVG in apps/server/src/assets/AssetAccess.ts t3 logo

Verification

  • vp check — 0 errors
  • vp run typecheck — passes

🤖 Generated with Claude Code


Note

Low Risk
Static branding asset only; no runtime, auth, or data-path changes.

Overview
Adds favicon.svg at the repository root (prod T3 mark copied from brand assets). No application or server code changes.

When this repo is opened in t3 code, ProjectFaviconResolver can use its first candidate path (favicon.svg at the workspace root) instead of falling back to the generic folder icon in the sidebar/thread list.

Reviewed by Cursor Bugbot for commit 1e48b1e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add repo-root favicon.svg to display the t3 code icon

Adds a favicon.svg at the repository root so the t3 codebase displays its own browser tab icon.

Macroscope summarized 1e48b1e.

ProjectFaviconResolver checks root-level favicon.svg first, but this
repo only had favicons nested under apps/*/public, so t3 code rendered
the generic folder fallback for its own workspace. Copy the prod brand
mark (assets/prod/logo.svg) to the repo root where the resolver finds it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0134046c-048c-444a-8f2d-c2c7ff86249e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/00c9d048-7327-49a6-b478-5b764e5ed094

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jul 3, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Adds a static favicon.svg asset with no runtime behavior impact - purely cosmetic branding file containing standard SVG path elements.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant