Add repo-root favicon.svg so t3 code shows its own icon#3683
Conversation
ProjectFaviconResolver checks root-level favicon.svg first, but this repo only had favicons nested under apps/*/public, so t3 code rendered the generic folder fallback for its own workspace. Copy the prod brand mark (assets/prod/logo.svg) to the repo root where the resolver finds it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Adds a static favicon.svg asset with no runtime behavior impact - purely cosmetic branding file containing standard SVG path elements. You can customize Macroscope's approvability policy. Learn more. |
What changed
Copied the prod brand mark (
assets/prod/logo.svg, 1 KB) tofavicon.svgat the repo root. One new file, no code changes.Why it should exist
ProjectFaviconResolverchecksfavicon.svgat the workspace root as its first candidate, but this repo only has favicons nested underapps/*/public— paths the resolver never checks. So when you open the t3code repo in t3 code itself, the sidebar/thread list renders the generic folder fallback instead of the T3 logo. With this file in place, the resolver's first candidate hits and the app shows its own icon.The SVG was chosen over the
.icovariants because it's the smallest asset, scales crisply, and is the prod mark (the "blueprint" icons are dev/nightly branding).Before / after
FALLBACK_PROJECT_FAVICON_SVGinapps/server/src/assets/AssetAccess.tsVerification
vp check— 0 errorsvp run typecheck— passes🤖 Generated with Claude Code
Note
Low Risk
Static branding asset only; no runtime, auth, or data-path changes.
Overview
Adds
favicon.svgat the repository root (prod T3 mark copied from brand assets). No application or server code changes.When this repo is opened in t3 code,
ProjectFaviconResolvercan use its first candidate path (favicon.svgat the workspace root) instead of falling back to the generic folder icon in the sidebar/thread list.Reviewed by Cursor Bugbot for commit 1e48b1e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add repo-root favicon.svg to display the t3 code icon
Adds a favicon.svg at the repository root so the t3 codebase displays its own browser tab icon.
Macroscope summarized 1e48b1e.