Skip to content

fix: ThreadErrorBanner tooltip#3682

Open
andredsnogueira wants to merge 2 commits into
pingdotgg:mainfrom
andredsnogueira:fix/thread-error-banner-tooltip
Open

fix: ThreadErrorBanner tooltip#3682
andredsnogueira wants to merge 2 commits into
pingdotgg:mainfrom
andredsnogueira:fix/thread-error-banner-tooltip

Conversation

@andredsnogueira

@andredsnogueira andredsnogueira commented Jul 3, 2026

Copy link
Copy Markdown

What Changed

ThreadErrorBanner was updated so the tooltip wraps only the error text (), not the whole AlertDescription.

Why

ThreadErrorBanner UI was broken as you can see from this issue #3635.

UI Changes

Before After
image image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Single-component UI markup fix with no auth, data, or API impact.

Overview
Fixes broken ThreadErrorBanner layout by changing how the error tooltip is composed.

AlertDescription now wraps the full Tooltip block. The TooltipTrigger uses a span with line-clamp-3 for the truncated error text instead of rendering AlertDescription as the trigger element, so the dismiss action and alert chrome stay outside the tooltip target.

Reviewed by Cursor Bugbot for commit 7773a2c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix tooltip structure in ThreadErrorBanner component

Restructures the tooltip in ThreadErrorBanner.tsx so that AlertDescription wraps the entire Tooltip block, rather than being used as the TooltipTrigger rendered element. The trigger is now a span with line-clamp-3 styling.

Macroscope summarized 7773a2c.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4d0e96ef-33c6-4e6f-880e-4914bd2bd24c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jul 3, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Simple UI fix that restructures tooltip/alert component nesting to fix tooltip rendering. The change is purely presentational with no logic or behavior changes, affecting only one component.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant