feat(server): replace Claude Agent SDK runtime with a direct stream-json CLI driver (subscription billing)#2729
Conversation
Replace the @anthropic-ai/claude-agent-sdk runtime with a direct stream-json child-process driver so usage bills against the user's Claude subscription instead of pay-per-token API credits. The SDK is now a type-only devDependency (zero runtime code, types unchanged). - ClaudeCliTransport.ts (new): spawn + NDJSON framing + control protocol (interrupt/setModel/setPermissionMode/setMaxThinkingTokens), can_use_tool permission bridge over stdio, initialize handshake - ClaudeAdapter.ts: createQuery -> makeClaudeCliQuery; import type only - ClaudeProvider.ts: capabilities/auth probe ported off SDK runtime - package.json: SDK moved dependencies -> devDependencies - ClaudeCliTransport.test.ts (new): protocol integration tests
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8dc80e8. Configure here.
| reject(error); | ||
| } | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Silent write failure leaves pending control promises orphaned
Medium Severity
writeLine internally catches all errors and never throws, so the try/catch around it in sendControlRequest is dead code. If writeLine silently returns without writing (because !child.stdin.writable is true while closed and exited are still false — e.g. after the prompt pump's finally block ends stdin), the pending control promise is registered in pendingControl but the message is never sent. The promise hangs until the process exits and the close handler rejects all pending entries. Methods like interrupt(), setModel(), etc. can appear to hang in this window.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 8dc80e8. Configure here.
ApprovabilityVerdict: Needs human review This PR replaces core SDK runtime infrastructure with a custom CLI transport and explicitly affects billing behavior (subscription vs API credits). The stated billing rationale combined with the scope of the infrastructure change and an unresolved bug finding warrants careful human review. You can customize Macroscope's approvability policy. Learn more. |
1 participant
I know it will never be merged, but, it's alternative solution not to create emdash/cmax for claude. We can spawn claude process!
Ive not reviewed the code (working on internal browser integration and dont want to spend time on this pr)