fix: stop working timer when agent is awaiting user input#1348
Draft
rdoupe wants to merge 3 commits intopingdotgg:mainfrom
Draft
fix: stop working timer when agent is awaiting user input#1348rdoupe wants to merge 3 commits intopingdotgg:mainfrom
rdoupe wants to merge 3 commits intopingdotgg:mainfrom
Conversation
The isWorking flag was computed before pendingUserInputs, so it never accounted for the agent being in a paused state waiting for user input. This caused the "Working for Xm Xs" timer to keep counting indefinitely even after the agent had asked a question and was no longer actively running. Fixes pingdotgg#1069, closes pingdotgg#1335 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Two locations showed stale "Working" state after the agent finished: 1. ChatView.tsx - "Working for Xm Xs" timer in the main chat 2. Sidebar.logic.ts - "Working" pill on thread list items Root cause: both checked only session.status === "running", but the server can lag in transitioning that status even after the latest turn has a completedAt timestamp. Also, neither checked for pending user inputs, so the timer kept running when the agent was blocked waiting for the user to answer a question. Fix: suppress "working" state when latestTurn.completedAt is set (turn is done regardless of server status lag), or when there are pending user inputs (agent is waiting, not working). Fixes pingdotgg#1069, closes pingdotgg#1335 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Two locations showed stale "Working" state after the agent finished:
ChatView.tsx— "Working for Xm Xs" timer in the main chat areaSidebar.logic.ts— "Working" pill on thread list itemsBoth checked only
session.status === "running"to decide whether to show the working state.Why
The server can lag in transitioning
session.statusaway from"running"even after the latest turn has acompletedAttimestamp. This caused:AskUserQuestion)Fix: suppress working state when
latestTurn.completedAtis set (turn is done, regardless of server status lag), or whenpendingUserInputs.length > 0(agent is waiting on the user, not actively working).UI Changes
Checklist
Fixes #1069, closes #1335