fix: quote editor launch args with spaces on Windows#1331
Open
C-W-D-Harshit wants to merge 1 commit intopingdotgg:mainfrom
Open
fix: quote editor launch args with spaces on Windows#1331C-W-D-Harshit wants to merge 1 commit intopingdotgg:mainfrom
C-W-D-Harshit wants to merge 1 commit intopingdotgg:mainfrom
Conversation
On Windows, spawn uses shell mode to resolve .cmd/.bat editor commands. This causes paths with spaces to be split into multiple arguments. Quote args containing spaces so the shell treats them as a single value. Fixes pingdotgg#757
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Quote arguments containing spaces when launching editors on Windows.
Why
On Windows,
spawnusesshell: trueto resolve.cmd/.bateditor commands (likecode.cmdfor VS Code). This causes the shell to split path arguments at spaces, so a path likeC:\Users\John Doe\projectopens two separate buffers instead of one.Prior attempts
shell: false)This PR only quotes args that contain spaces, and only when
shell: true(Windows). Non-Windows platforms pass args as arrays and are unaffected.Fixes #757
Checklist