fix(git): increase commit timeout for slow pre-commit hooks#1330
Open
C-W-D-Harshit wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(git): increase commit timeout for slow pre-commit hooks#1330C-W-D-Harshit wants to merge 1 commit intopingdotgg:mainfrom
C-W-D-Harshit wants to merge 1 commit intopingdotgg:mainfrom
Conversation
The git commit command used the default 30s timeout which causes failures for repositories with slow pre-commit hooks (e.g. linting, type-checking). Increase to 120s so hooks have time to complete. Fixes pingdotgg#1194
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Increased the
git commitcommand timeout from 30s to 120s.Why
Repositories with slow pre-commit hooks (linting, type-checking, formatting) regularly exceed the hardcoded 30s default timeout, causing the commit to fail with a timeout error in the UI. The hook itself succeeds — it just needs more time.
The 120s limit matches common CI expectations for pre-commit hook runtimes while still catching genuinely stuck processes.
Only the commit path is changed. All other git operations keep the existing 30s default.
Fixes #1194
Checklist
Note
Increase git commit timeout to 120 seconds for slow pre-commit hooks
Replaces
runGitwithexecuteGitinGitCore.committo pass an explicittimeoutMs: 120000option, up from the previous default. This prevents premature failures when pre-commit hooks take a long time to run.Macroscope summarized f13bf0d.