fix: add noopener to external chat markdown links#1315
fix: add noopener to external chat markdown links#1315sabraman wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
Summary
noopeneralongsidenoreferrerfor external links rendered byChatMarkdownWhy
Markdown links that do not resolve to local file targets open in a new tab from
ChatMarkdown, but they were the only new-tab links in the repo still usingrel="noreferrer"alone. The rest of the app and marketing site consistently userel="noopener noreferrer"for that pattern.Verification
Note
Add
noopenerto external links in chat markdown rendererUpdates the
arenderer in ChatMarkdown.tsx to includerel="noopener noreferrer"(previously onlynoreferrer) on external links opened in a new tab. This prevents the new page from accessingwindow.openeron the source tab.Macroscope summarized da0bc1e.