fix(desktop): persist window size and restore macOS fullscreen exits cleanly#1170
Open
rushilrai wants to merge 2 commits intopingdotgg:mainfrom
Open
fix(desktop): persist window size and restore macOS fullscreen exits cleanly#1170rushilrai wants to merge 2 commits intopingdotgg:mainfrom
rushilrai wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR makes the desktop app remember its last window state across relaunches.
It restores:
The restore logic keeps normal restore bounds separate from the fullscreen-origin visible frame so standard maximize behaviour stays intact.
Why
Right now the desktop app always comes back at the default size, which is frustrating if you keep it in a specific layout.
This change makes relaunch behavior feel much closer to what users expect from native desktop apps.
UI Changes
Desktop window restore behaviour only.
Checklist
Note
Persist window size and restore macOS fullscreen state across sessions
loadWindowStateandattachWindowStatePersistenceto save/restore window bounds and mode touserData/window-state.json.normal,maximized, orfullscreen-origin); falls back to a centered default (1100×780) if the saved state is missing, invalid, or off-screen.restoreMode: 'fullscreen-origin'to track this case.console.warn.Macroscope summarized 1a0662d.
Note
Medium Risk
Changes Electron window creation/startup behavior and introduces new disk persistence logic; mistakes could cause bad restore geometry or startup regressions, though it falls back safely when state is invalid/off-screen.
Overview
The desktop app now persists window bounds and restore mode to
userData/window-state.jsonand restores them on launch, instead of always using fixed default dimensions.Adds
windowState.tswithloadWindowState(validates/clamps bounds, ensures the window is sufficiently on-screen, and centers defaults when missing/invalid) andattachWindowStatePersistence(debounced move/resize persistence, immediate flush on close/maximize/fullscreen toggles, with a specialfullscreen-originmode to avoid macOS fullscreen re-entry/white flash). Includes a comprehensivevitestsuite covering restore fallbacks, visibility checks, and persistence behavior.Written by Cursor Bugbot for commit 1a0662d. This will update automatically on new commits. Configure here.