sink(ticdc): fix a bug that may cause data loss while closing Writer failed (#12437)#12443
sink(ticdc): fix a bug that may cause data loss while closing Writer failed (#12437)#12443ti-chi-bot wants to merge 2 commits intopingcap:release-8.1from
Conversation
ti-chi-bot
added
lgtm
release-note
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical data integrity issue within the TiCDC cloud storage sink. By modifying the error handling logic for closing data writers, it ensures that any failure during the finalization of data uploads is properly detected and acted upon. This prevents scenarios where DMLs might be silently lost, promoting robust and reliable data replication. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a potential data loss bug where an error from writer.Close was ignored. The change correctly propagates the error from writer.Close on a successful write. However, the change introduces a potential resource leak by not closing the writer if writer.Write fails. I've added a comment with a suggestion to fix this.
| } | ||
| }() | ||
| if _, inErr = writer.Write(ctx, buf.Bytes()); inErr != nil { | ||
| return 0, 0, inErr |
There was a problem hiding this comment.
While this change correctly handles the error from writer.Close() on the success path, it introduces a potential resource leak. If writer.Write() on line 281 fails, the function returns without closing the writer. The storage.Writer is an io.WriteCloser and must be closed to release underlying resources (like file descriptors or incomplete multipart uploads on S3). Failure to do so can lead to resource exhaustion.
The writer should be closed even when Write fails. The error from Close in this case should be logged, but the original error from Write should be returned.
| return 0, 0, inErr | |
| if closeErr := writer.Close(ctx); closeErr != nil { | |
| log.Warn("failed to close writer after write error", zap.Error(closeErr), zap.Int("workerID", d.id), zap.Any("table", task.tableInfo.TableName)) | |
| } | |
| return 0, 0, inErr | |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.0000%) is below the target coverage (60.0000%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #12443 +/- ##
================================================
Coverage ? 57.2706%
================================================
Files ? 854
Lines ? 126688
Branches ? 0
================================================
Hits ? 72555
Misses ? 48681
Partials ? 5452 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This is an automated cherry-pick of #12437
What problem does this PR solve?
Issue Number: close #12436
What is changed and how it works?
In the previous implementation, the error of
writer.Closewas not handled, and some DMLs may upload failed.This error should block the advance and cause the changefeed to finally restart.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note