dm: draft PR for aeon temp builds

[OliverS929]

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter, yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• dm/OWNERS
• dm/config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @OliverS929, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration parameter, EventCacheCount, to enhance the configurability of the data migration (DM) syncer and validator components. This parameter allows users to specify the size of an internal event cache, providing more granular control over resource usage and potentially optimizing performance. The changes involve defining the parameter, establishing a default value, and updating the configuration loading and adjustment mechanisms to properly utilize this new setting.

Highlights

• New Configuration Parameter: Introduced EventCacheCount as a new configuration parameter for both SyncerConfig and ValidatorConfig within the dm module.
• Default Value Assignment: A default value of 10240 has been set for EventCacheCount, which is applied if the parameter is not explicitly specified in the configuration.
• Configuration Integration: The new EventCacheCount parameter is integrated into the configuration adjustment logic, default constructors, and the downgrade compatibility structure (SyncerConfigForDowngrade).
• Binlog Syncer Configuration Update: The subtaskCfg2BinlogSyncerCfg utility function now accepts eventCacheCount as an argument and passes it to the underlying replication.BinlogSyncerConfig.
• Unit Test Coverage: A new unit test has been added to dm/syncer/util_test.go to ensure the correct handling and propagation of the EventCacheCount parameter.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OliverS929]

/hold

[gemini-code-assist]

Code Review

This pull request introduces a new configuration option, EventCacheCount, for both the syncer and validator components. The changes are well-integrated into the configuration loading, default value handling, and component initialization logic. A new test case has been added to verify the functionality. My review focuses on improving the clarity and maintainability of the new configuration options by adding comments.

[gemini-code-assist]

It's good practice to add a comment explaining the purpose and impact of this default value, similar to defaultQueueSize. This helps users understand the configuration better.

Suggested change

	defaultEventCacheCount = 10240
	defaultEventCacheCount = 10240 // the count of binlog event cache. If you have a large transaction, you may need to enlarge it.

[gemini-code-assist]

For better maintainability and user-friendliness, please add a comment explaining what EventCacheCount is for, similar to how other fields in this struct are commented.

Suggested change

	EventCacheCount int `yaml:"event-cache-count" toml:"event-cache-count" json:"event-cache-count"`
	// EventCacheCount is the count of binlog event cache. If you have a large transaction, you may need to enlarge it.
	EventCacheCount int `yaml:"event-cache-count" toml:"event-cache-count" json:"event-cache-count"`

[gemini-code-assist]

To improve configuration clarity for users, please add a comment for EventCacheCount explaining its purpose.

Suggested change

	EventCacheCount int `yaml:"event-cache-count" toml:"event-cache-count" json:"event-cache-count"`
	// EventCacheCount is the count of binlog event cache. If you have a large transaction, you may need to enlarge it.
	EventCacheCount int `yaml:"event-cache-count" toml:"event-cache-count" json:"event-cache-count"`

[ti-chi-bot]

@OliverS929: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-verify	bae2dc9	link	true	/test pull-verify
pull-dm-integration-test	bae2dc9	link	true	/test pull-dm-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.