Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 20, 2025

What problem does this PR solve?

Issue Number: close #12207

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

The privilege checker was improved to better handle MariaDB specific privileges

Hold

Once the pingcap/tidb PR that this depends on has been merged this commit should be updated to:

  • Use the commit from that PR for the parser (or newer)
  • Remove the replace lines in go.mod for pingcap/tidb and the parser.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dm Issues or PRs related to DM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Nov 23, 2025
@dveeden dveeden changed the title WIP: MariaDB DM: Improve MariaDB permission handling Nov 23, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Nov 23, 2025

/type feature

@ti-chi-bot ti-chi-bot bot added the type/feature Issues about a new feature label Nov 23, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Nov 23, 2025

/unlabel type/feature

@dveeden dveeden marked this pull request as ready for review November 23, 2025 14:11
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Nov 23, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Nov 23, 2025

/cc @lance6716 @D3Hunter

@ti-chi-bot ti-chi-bot bot requested review from D3Hunter and lance6716 November 23, 2025 14:24
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 23, 2025

@dveeden: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 722139d link true /test pull-verify
pull-dm-integration-test 722139d link true /test pull-dm-integration-test
pull-cdc-integration-kafka-test 722139d link true /test pull-cdc-integration-kafka-test
pull-cdc-integration-storage-test 722139d link true /test pull-cdc-integration-storage-test
pull-cdc-integration-pulsar-test 722139d link true /test pull-cdc-integration-pulsar-test
pull-syncdiff-integration-test 722139d link true /test pull-syncdiff-integration-test
pull-cdc-integration-mysql-test 722139d link true /test pull-cdc-integration-mysql-test
pull-dm-compatibility-test 722139d link true /test pull-dm-compatibility-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 29, 2025

/cc @OliverS929

@ti-chi-bot ti-chi-bot bot requested a review from OliverS929 November 29, 2025 09:44
Comment on lines +447 to +449
replace github.com/pingcap/tidb/pkg/parser => /home/dvaneeden/dev/pingcap/tidb/pkg/parser

replace github.com/pingcap/tidb => /home/dvaneeden/dev/pingcap/tidb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the commit in pingcap/tidb that's needed for this PR to function is merged I will do that. This is mentioned in the description and this is the reason for the hold label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dm Issues or PRs related to DM. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/feature Issues about a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DM fails when checking privileges due to unsupported syntax on MariaDB

2 participants