-
Notifications
You must be signed in to change notification settings - Fork 298
DM: Improve MariaDB permission handling #12404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. |
|
/type feature |
|
/unlabel type/feature |
|
/hold |
|
/cc @lance6716 @D3Hunter |
|
@dveeden: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @OliverS929 |
| replace github.com/pingcap/tidb/pkg/parser => /home/dvaneeden/dev/pingcap/tidb/pkg/parser | ||
|
|
||
| replace github.com/pingcap/tidb => /home/dvaneeden/dev/pingcap/tidb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the commit in pingcap/tidb that's needed for this PR to function is merged I will do that. This is mentioned in the description and this is the reason for the hold label.
What problem does this PR solve?
Issue Number: close #12207
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Hold
Once the pingcap/tidb PR that this depends on has been merged this commit should be updated to:
replacelines in go.mod for pingcap/tidb and the parser.