Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10325

What problem does this PR solve?

Issue Number: close #10324

Problem Summary:

What is changed and how it works?

Storages: Deprecated libclara for normal build
  * Add `ENABLE_CLARA` and disable it by default in normal build
  * Exclude the files under `dbms/src/Storages/DeltaMerge/Index/FullTextIndex` when `ENABLE_CLARA` is disabled

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Both debug and release build in local env is success
# Debug build
>  ninja -j 32 tiflash gtests_dbms gtests_libcommon
>  ./dbms/src/Server/tiflash version
TiFlash
Release Version: v9.0.0-beta.2.pre-15-g33e88b3667
Edition:         Community
Git Commit Hash: 33e88b36675ec72288bda52b5c296e3f55789d43
Git Branch:      deprecated_clara
UTC Build Time:  2025-08-04 04:57:48
Enable Features: jemalloc sm4(GmSSL) mem-profiling failpoints avx2 avx512 unwind hnsw.l2=skylake hnsw.cosine=skylake vec.l2=skylake vec.cos=skylake
Profile:         DEBUG
Compiler:        clang++ 17.0.6

Raft Proxy
Git Commit Hash:   3e325b2b9b30e396c846bfeb97a690d070b84087
Git Commit Branch: HEAD
UTC Build Time:    ""   
Rust Version:      rustc 1.77.0-nightly (89e2160c4 2023-12-27)
Storage Engine:    tiflash
Prometheus Prefix: tiflash_proxy_
Profile:           debug
Enable Features:   external-jemalloc portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine openssl-vendored

# Release build
> ninja -j 32 tiflash
>  ./dbms/src/Server/tiflash version
TiFlash
Release Version: v9.0.0-beta.2.pre-15-g33e88b3667
Edition:         Community
Git Commit Hash: 33e88b36675ec72288bda52b5c296e3f55789d43
Git Branch:      deprecated_clara
UTC Build Time:  2025-08-04 04:57:30
Enable Features: jemalloc sm4(GmSSL) mem-profiling avx2 avx512 unwind hnsw.l2=skylake hnsw.cosine=skylake vec.l2=skylake vec.cos=skylake
Profile:         RelWithDebInfo
Compiler:        clang++ 17.0.6

Raft Proxy
Git Commit Hash:   3e325b2b9b30e396c846bfeb97a690d070b84087
Git Commit Branch: HEAD
UTC Build Time:    ""   
Rust Version:      rustc 1.77.0-nightly (89e2160c4 2023-12-27)
Storage Engine:    tiflash
Prometheus Prefix: tiflash_proxy_
Profile:           release
Enable Features:   external-jemalloc portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine openssl-vendored
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20250815 labels Aug 4, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 5, 2025
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-05 02:18:07.564690521 +0000 UTC m=+320997.707451696: ☑️ agreed by JinheLin.
  • 2025-08-05 02:52:35.392526904 +0000 UTC m=+323065.535288079: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit d936f1e into pingcap:release-nextgen-20250815 Aug 5, 2025
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-10325-to-release-nextgen-20250815 branch August 5, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20250815

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants