Skip to content

tici: auto-generate TiCI changefeed sinkURI from s3 config#6752

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.xfrom
3pointer:auto_gen_gcs_sinkuri
Mar 13, 2026
Merged

tici: auto-generate TiCI changefeed sinkURI from s3 config#6752
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.xfrom
3pointer:auto_gen_gcs_sinkuri

Conversation

@3pointer
Copy link
Copy Markdown
Contributor

@3pointer 3pointer commented Mar 4, 2026

Summary

  • auto-generate TiCI changefeed sinkURI from spec.tici.s3 when spec.tici.changefeed.sinkURI is empty
  • detect GCS endpoint (storage.googleapis.com) and generate gcs://...; keep existing MinIO/S3 behavior
  • preserve existing guard: changefeed is only created when TiCI is configured
  • add tests for MinIO/GCS auto-generation, sinkURI override, and disabled/no-TiCI cases
  • update GCS examples/docs to rely on auto-generated sinkURI

Testing

  • go test ./pkg/manager/member/startscript/v1 ./pkg/manager/member/startscript/v2

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Mar 4, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lybcodes
Copy link
Copy Markdown
Contributor

/test pull-e2e-kind-dmcluster

@lybcodes
Copy link
Copy Markdown
Contributor

/test pull-e2e-kind-basic

@lybcodes
Copy link
Copy Markdown
Contributor

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Mar 12, 2026

@3pointer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-kind-dmcluster 7a6567e link false /test pull-e2e-kind-dmcluster
pull-e2e-kind-br 7a6567e link false /test pull-e2e-kind-br
pull-e2e-kind-basic 7a6567e link false /test pull-e2e-kind-basic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 13, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Mar 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-13 10:16:53.633363874 +0000 UTC m=+1670.634137342: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit 9502f93 into pingcap:release-1.x Mar 13, 2026
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants