metrics,grafana: show changefeed downstream type (#4251)#5330
metrics,grafana: show changefeed downstream type (#4251)#5330ti-chi-bot wants to merge 2 commits into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@wlwilliamx This PR has conflicts, I have hold it. |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlwilliamx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/test all |
This is an automated cherry-pick of #4251
What problem does this PR solve?
Issue Number: close #4250
What is changed and how it works?
ticdc_owner_changefeed_downstream_info{namespace|keyspace_name, changefeed, downstream_type} 1to expose downstream type per changefeed.downstream_typefrom the sink-uri scheme and normalize it to a small stable set (e.g.mysql+ssl->mysql,pulsar+https->pulsar,gs->gcs,azure->azblob).Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. This PR only adds an additive metric and dashboard panel, and the per-changefeed metric update is on the same 5s loop as existing changefeed metrics.
Do you need to update user documentation, design documentation or monitoring documentation?
Monitoring dashboard is updated.
Release note
Summary by CodeRabbit
New Features
Bug Fixes
Behavior
Tests