[wip]

[wk989898]

What problem does this PR solve?

Issue Number: close #4939

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenfyzhong for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8264ff8-fe12-4e83-95e6-ff61bc1ab43b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request introduces a tableCRTsCollector to track commit timestamp ranges within Pebble SSTables, enabling the event store iterator to skip irrelevant data via a TableFilter. It also refactors key decoding logic and includes comprehensive tests for the new functionality. Feedback suggests prefixing table property labels to prevent naming collisions and adding defensive bounds checks to the DecodeKeyMetas function to avoid potential panics.

[gemini-code-assist]

The property labels used here are quite generic (minCRTs, maxCRTs). To avoid potential collisions with other table property collectors that might be added in the future, it is recommended to prefix these labels with the collector name.

Suggested change

	minTableCRTsLabel = "minCRTs"
	maxTableCRTsLabel = "maxCRTs"
	tableCRTsCollectorName = "table-crts-collector"
	minTableCRTsLabel = "table-crts-collector.minCRTs"
	maxTableCRTsLabel = "table-crts-collector.maxCRTs"
	tableCRTsCollectorName = "table-crts-collector"

[gemini-code-assist]

The DecodeKeyMetas function is exported and performs a slice access key[eventStoreKeyMetaOffset : eventStoreKeyMetaOffset+2] without checking the length of the input key. While internal callers might guarantee the length, as a public function it should be defensive against shorter keys to avoid panics.

func DecodeKeyMetas(key []byte) (DMLOrder, CompressionType) {
	if len(key) < eventStoreKeyMetaOffset+2 {
		return DMLOrderDelete, CompressionNone
	}
	combinedOrder := binary.BigEndian.Uint16(key[eventStoreKeyMetaOffset : eventStoreKeyMetaOffset+2])