Skip to content

consumer: fix pulsar consumer stuck after broker restart #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wk989898 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

consumer: fix pulsar consumer stuck after broker restart #4904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions cmd/pulsar-consumer/consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,26 +99,24 @@ func newConsumer(ctx context.Context, option *option) *consumer {
}

func (c *consumer) readMessage(ctx context.Context) error {
msgChan := c.pulsarConsumer.Chan()
defer func() {
c.pulsarConsumer.Close()
c.client.Close()
}()
for {
select {
case <-ctx.Done():
log.Info("terminating: context cancelled")
return errors.Trace(ctx.Err())
case consumerMsg := <-msgChan:
log.Debug("Received message", zap.Stringer("msgId", consumerMsg.ID()), zap.ByteString("content", consumerMsg.Payload()))
needCommit := c.writer.WriteMessage(ctx, consumerMsg)
if !needCommit {
continue
}
err := c.pulsarConsumer.AckID(consumerMsg.Message.ID())
if err != nil {
log.Panic("Error ack message", zap.Error(err))
}
consumerMsg, err := c.pulsarConsumer.Receive(ctx)
if err != nil {
log.Error("Receive message error", zap.Error(err))
return errors.Trace(err)
}
Comment on lines +108 to +111
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation logs an error when the context is cancelled (e.g., during a graceful shutdown), as pulsarConsumer.Receive(ctx) returns context.Canceled. This is misleading because context cancellation is an expected way to stop the consumer. It's better to check for this specific error and log it at the Info level, consistent with the previous logic.

if err != nil {
			if errors.Cause(err) == context.Canceled {
				log.Info("terminating: context cancelled")
				return errors.Trace(err)
			}
			log.Error("Receive message error", zap.Error(err))
			return errors.Trace(err)
		}

log.Debug("Received message", zap.Stringer("msgId", consumerMsg.ID()), zap.ByteString("content", consumerMsg.Payload()))
needCommit := c.writer.WriteMessage(ctx, consumerMsg)
if !needCommit {
continue
}
err = c.pulsarConsumer.AckID(consumerMsg.ID())
if err != nil {
log.Panic("Error ack message", zap.Error(err))
}
}
}
Expand Down
Loading