Skip to content

kvrpcpb: change Context.stale_read from bool to enum#1274

Closed
crazycs520 wants to merge 6 commits intopingcap:masterfrom
crazycs520:test-stale-read-enum2
Closed

kvrpcpb: change Context.stale_read from bool to enum#1274
crazycs520 wants to merge 6 commits intopingcap:masterfrom
crazycs520:test-stale-read-enum2

Conversation

@crazycs520
Copy link
Copy Markdown

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot Bot added the size/XXL label Oct 23, 2024
@ti-chi-bot ti-chi-bot Bot requested a review from shihongzhi October 23, 2024 14:25
@crazycs520
Copy link
Copy Markdown
Author

@MyonKeminta @cfzjywxk PTAL

@cfzjywxk cfzjywxk requested review from MyonKeminta, cfzjywxk, ekexium, you06 and zyguan and removed request for shihongzhi October 23, 2024 14:47
Comment thread proto/kvrpcpb.proto Outdated
Copy link
Copy Markdown
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot Bot removed the approved label Oct 23, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta
Once this PR has been reviewed and has the lgtm label, please assign cfzjywxk, zhangjinpeng87 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk]
  • proto/OWNERS [cfzjywxk]

    Need more approvers for rest parts.

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-23 14:49:46.226912935 +0000 UTC m=+448986.923703563: ☑️ agreed by cfzjywxk.
  • 2024-10-23 16:47:34.476555188 +0000 UTC m=+456055.173345794: ☑️ agreed by MyonKeminta.

@cfzjywxk cfzjywxk added the DNM Do Not Merge label Oct 24, 2024
@ekexium
Copy link
Copy Markdown
Member

ekexium commented Apr 23, 2026

Closing because of inactivity

@ekexium ekexium closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants