Skip to content

Conversation

@zhangjinpeng87
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 commented Mar 29, 2024

Part of tikv/tikv#16708

  • Rename resolved_ts to name watermark if it is a field. Rename proto filed name without change its id is compatible.
  • Keep PD API rpc ReportMinResolvedTS(ReportMinResolvedTsRequest) returns (ReportMinResolvedTsResponse) {} for compatibility reason, at the same time add rpc ReportMinWatermark(ReportMinWatermarkRequest) returns (ReportMinWatermarkResponse) {} which will replace the former one in the future.

Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wuhuizuo
Once this PR has been reviewed and has the lgtm label, please assign bornchanger, cfzjywxk, lance6716, overvenus, rleungx, tonyxuqqi for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap pingcap deleted a comment from ti-chi-bot bot Apr 15, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 15, 2024

@wuhuizuo: Please do not delete or edit you lgtm type comment!

Details

In response to this:

/approve
/lgtm

just for test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant