fix: failpoint-toolexec not working on Windows#90
Merged
kennytm merged 1 commit intopingcap:masterfrom Apr 6, 2026
Merged
Conversation
On Windows, the compile command is never detected because `strings.TrimSuffix(goCmd, ".exe")` operates on the full path (e.g. `C:\...\compile.exe` → `C:\...\compile`) instead of the base name. The comparison `goCmdBase == "compile"` always fails. Fix: use `goCmdBase` instead of `goCmd` in TrimSuffix.
|
|
kennytm
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failpoint-toolexecsilently skips all failpoint injection on Windows due to a typo on line 40 offailpoint-toolexec/main.go.Bug:
strings.TrimSuffix(goCmd, ".exe")operates on the full path (C:\...\compile.exe→C:\...\compile) instead of the base name. The comparisongoCmdBase == "compile"always evaluates tofalse, so the compile command is never intercepted.Fix:
strings.TrimSuffix(goCmdBase, ".exe")Reproduction
On Windows,
failpoint.Injectmarkers are never rewritten when using-toolexec failpoint-toolexec. Tests that rely on failpoint injection silently pass without actually injecting errors.Verified by logging the values inside the toolexec binary:
🤖 Generated with Claude Code