Skip to content

zh translation workflow: fix manual Cloud translation cursor updates#22848

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
qiancai:fix-manual-cloud-translation-cursor
May 6, 2026
Merged

zh translation workflow: fix manual Cloud translation cursor updates#22848
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
qiancai:fix-manual-cloud-translation-cursor

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented May 6, 2026

What is changed, added or deleted? (Required)

This PR updates the Cloud ZH translation workflow so latest_translation_commit.json is only advanced during scheduled sync runs.

Manual workflow_dispatch runs that translate specific files now keep the translated file changes but skip the global cursor update. This prevents manually scoped translation PRs from moving the scheduled translation cursor.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2026
@qiancai qiancai changed the title fix manual Cloud translation cursor updates zh translation workflow: fix manual Cloud translation cursor updates May 6, 2026
@qiancai qiancai marked this pull request as ready for review May 6, 2026 02:09
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2026
@qiancai qiancai self-assigned this May 6, 2026
@qiancai qiancai added the translation/no-need No need to translate this PR. label May 6, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label May 6, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 6, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 6, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-06 02:11:36.518705063 +0000 UTC m=+233769.392055035: ☑️ agreed by lilin90.

@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented May 6, 2026

/approve

@qiancai qiancai added the lgtm label May 6, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 6, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 0f0d07e into pingcap:master May 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants