v5.4: update download URL from pingcap.org to pingcap.com #22243
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Oreoxmt
added
translation/from-docs-cn
ti-chi-bot
bot
added
the
size/M
Summary of ChangesHello @Oreoxmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical maintenance update for the v5.4 documentation. Its primary purpose is to ensure that all download links for TiDB components and related ecosystem tools point to the correct and current domain, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates download URLs from pingcap.org to pingcap.com across multiple documentation files. The changes are straightforward and correct. I've added a couple of minor suggestions to use https instead of http for consistency and improved security.
|
|
||
| ```bash | ||
| wget http://download.pingcap.org/dm-nightly-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/dm-nightly-linux-amd64.tar.gz |
There was a problem hiding this comment.
For consistency with other download links and for better security, it's recommended to use https instead of http.
| wget http://download.pingcap.com/dm-nightly-linux-amd64.tar.gz | |
| wget https://download.pingcap.com/dm-nightly-linux-amd64.tar.gz |
References
- The style guide emphasizes using consistent terminology (line 25). Using
httpsfor all download links improves consistency and security. (link)
| | Package name | OS | Architecture | SHA256 checksum | | ||
| |:---|:---|:---|:---| | ||
| | `http://download.pingcap.org/tidb-toolkit-{version}-linux-amd64.tar.gz` | Linux | amd64 | `http://download.pingcap.org/tidb-toolkit-{version}-linux-amd64.sha256` | | ||
| | `http://download.pingcap.com/tidb-toolkit-{version}-linux-amd64.tar.gz` | Linux | amd64 | `http://download.pingcap.com/tidb-toolkit-{version}-linux-amd64.sha256` | |
There was a problem hiding this comment.
For consistency with other download links in this file and for better security, it's recommended to use https instead of http for both URLs in this line.
| | `http://download.pingcap.com/tidb-toolkit-{version}-linux-amd64.tar.gz` | Linux | amd64 | `http://download.pingcap.com/tidb-toolkit-{version}-linux-amd64.sha256` | | |
| | `https://download.pingcap.com/tidb-toolkit-{version}-linux-amd64.tar.gz` | Linux | amd64 | `https://download.pingcap.com/tidb-toolkit-{version}-linux-amd64.sha256` | |
References
- The style guide emphasizes using consistent terminology (line 25). Using
httpsfor all download links improves consistency and security. (link)
1 participant
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?