Skip to content

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Dec 26, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt self-assigned this Dec 26, 2025
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 26, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @Oreoxmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical maintenance task: updating all download URLs within the documentation. The primary goal is to migrate all references from download.pingcap.org to download.pingcap.com, ensuring that users are always directed to the most current and authoritative download sources for TiDB, its ecosystem tools, and monitoring components. This change improves the reliability and accuracy of the provided installation and upgrade instructions.

Highlights

  • Download URL Update: All download links across various documentation files have been updated to use the download.pingcap.com domain instead of the older download.pingcap.org.
  • Documentation Consistency: This change ensures consistency in download sources, directing users to the current and correct location for TiDB components and related tools.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 26, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates download URLs from pingcap.org to pingcap.com across multiple documentation files. The changes are mostly correct. I've found a few minor inconsistencies in some of the updated files and provided suggestions to improve clarity and correctness. Specifically, in upgrade-monitoring-services.md, the example URLs were pointing to the wrong package, and in tidb-binlog/get-started-with-tidb-binlog.md, an example command was inconsistent and syntactically incorrect.


```
[kolbe@localhost ~]$ curl -LO https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | tar xzf -
[kolbe@localhost ~]$ curl -LO https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | tar xzf -

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The command in the example output is inconsistent with the command provided above it (line 45). Also, the use of curl -LO ... | tar ... is incorrect because the -O flag saves the output to a file instead of stdout, leaving nothing for tar to read from the pipe. To maintain consistency and correctness, I suggest updating the command in the example output to match the one on line 45.

Suggested change
[kolbe@localhost ~]$ curl -LO https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | tar xzf -
[kolbe@localhost ~]$ curl -L https://download.pingcap.com/tidb-community-server-v6.1.7-linux-amd64.tar.gz | tar xzf -

> **Tip:**
>
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v6.1.0-linux-amd64.tar.gz`.
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v6.1.0-linux-amd64.tar.gz`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The example download link refers to tidb-community-toolkit, but the context is about downloading the tidb-community-server package. To avoid confusion, it's better to make the example consistent with the context.

Suggested change
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v6.1.0-linux-amd64.tar.gz`.
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v6.1.0-linux-amd64.tar.gz`.

> **Tip:**
>
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v6.1.0-linux-amd64.tar.gz`.
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v6.1.0-linux-amd64.tar.gz`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Similar to the previous section, the example download link here refers to tidb-community-toolkit, while the context is about downloading the tidb-community-server package. For clarity, I suggest updating the example URL to point to the server package.

Suggested change
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v6.1.0-linux-amd64.tar.gz`.
> `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v6.1.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v6.1.0-linux-amd64.tar.gz`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant