tiup: clarify limits.conf behavior in no-sudo mode#21729
Conversation
|
Hi @doc-claw-bot. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
There was a problem hiding this comment.
Pull request overview
This PR updates the Chinese TiUP no-sudo deployment documentation to clarify how file descriptor limits (nofile) actually take effect under per-user systemd (user@<UID>.service) and to provide concrete verification and remediation steps.
Changes:
- Explain why
/etc/security/limits.confmay not fully determine the effectiveMax open filesfor the per-usersystemdmanager in no-sudo mode. - Add steps to restart
user@${uid}.serviceafter updating limits, verify the effective limit via/proc/<pid>/limits, and document a system-level drop-in fallback usingLimitNOFILE=1000000.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $ systemctl restart user@${uid}.service | ||
| ``` | ||
|
|
||
| 3. 检查运行中的 `user@${uid}.service` 实际生效的 `Max open files` 值。 |
What is changed, added or deleted? (Required)
This PR updates the Chinese TiUP no-sudo documentation to clarify how resource limits take effect for the per-user
systemdmanager./etc/security/limits.confmight be applied through PAM whenuser@<UID>.servicestarts, but the effectiveMax open filesvalue still depends on the limits obtained by the user manager itself.Max open filesvalue of the runninguser@${uid}.service.user@${uid}.servicewithLimitNOFILE=1000000.user@${uid}.servicestops all user services managed by that user, so existing clusters should be stopped first or handled in a maintenance window.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?