Upgrade tsup v6 → v8 and tsx v3 → v4 (dev tooling)#20
Merged
Conversation
The remaining dev-tooling advisories came from stale build tools: tsup@6 and tsx@3 bundled an old esbuild, and tsx@3 pulled the deprecated @esbuild-kit/* packages (esbuild dev-server SSRF, tsup DOM clobbering). - tsup ^6.7.0 -> ^8.5.1 - tsx ^3.12.3 -> ^4.23.0 (drops @esbuild-kit/*, bundles current esbuild) npm audit: 3 moderate -> 1 low. The three moderates are gone. The one remaining low (esbuild GHSA-g7r4-m6w7-qqqr: arbitrary file read via the dev server on Windows) has no upstream fix yet: tsup@8.5.1 still caps esbuild at ^0.27, so it resolves 0.27.7 while tsx/vitest already use the fixed 0.28.1. It is dev-only and Windows-only, the audit CI job is non-blocking, and it becomes a no-op the moment tsup widens its esbuild range. Left override-free by choice to keep the tree honest. Verified: npm run build (tsup 8 emits identical dist), npm test (23 pass), npm run lint, npm run format:check all green, and `tsx -r dotenv/config` still preloads env (so `npm run recommend` keeps working) under tsx 4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause #4 — the remaining dev-tooling alerts
The last three moderates came from stale build tools:
tsup@6andtsx@3bundled an old esbuild, andtsx@3pulled the deprecated@esbuild-kit/*packages.Changes
tsup^6.7.0→^8.5.1tsx^3.12.3→^4.23.0(drops@esbuild-kit/*, bundles current esbuild)Impact
npm audit: 3 moderate → 1 low. The three moderates (esbuild dev-server SSRF, tsup DOM clobbering, tsx via@esbuild-kit) are gone.The one remaining low (left override-free, by choice)
esbuildGHSA-g7r4-m6w7-qqqr — arbitrary file read via the dev server on Windows. It has no upstream fix:tsup@8.5.1still caps esbuild at^0.27, so it resolves0.27.7, whiletsx/vitestalready use the fixed0.28.1. It's dev-only + Windows-only, theauditCI job is non-blocking, and it becomes a no-op the moment tsup widens its esbuild range. A one-lineoverrides: { esbuild: "^0.28.1" }would zero it out (verified), but we're keeping the tree override-free per the approach taken across this whole effort.Verification
npm run build— tsup 8 emits identicaldist.npm test(23 pass),npm run lint,npm run format:check— green.tsx -r dotenv/configstill preloads env under tsx 4, sonpm run recommendkeeps working.🤖 Generated with Claude Code