Skip to content

chunk size hard coded to 100#1

Open
joelhooks wants to merge 1 commit into
pinecone-io:mainfrom
joelhooks:jh/fix-hard-coded-chunk-size-in-ts-example
Open

chunk size hard coded to 100#1
joelhooks wants to merge 1 commit into
pinecone-io:mainfrom
joelhooks:jh/fix-hard-coded-chunk-size-in-ts-example

Conversation

@joelhooks

Copy link
Copy Markdown

Problem

The chunkSize is passed as a param but is then hard coded as 100

Solution

Used the chunkSize param and remove ed the hard coded 100.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Run the example and the progress bar displays the correct value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant