Fix RuleActions drag and drop by passing onChange prop#2941
Merged
markus-moser merged 3 commits into1.xfrom Feb 12, 2026
Merged
Fix RuleActions drag and drop by passing onChange prop#2941markus-moser merged 3 commits into1.xfrom
markus-moser merged 3 commits into1.xfrom
Conversation
The RuleActions component was not passing the onChange prop to RuleItemList, causing drag and drop reordering to not persist. The handleDragEnd function in RuleItemList was correctly calling onChange but it was never wired through from RuleActions to the form field.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes drag and drop reordering of rule actions not persisting.
The RuleActions component was not passing the onChange prop to RuleItemList, causing the reordered state to not be saved to the form.