Conversation
xIrusux
approved these changes
Jan 28, 2026
| setIsDeleting(true) | ||
| deleteElement(id, label, undefined, () => { | ||
| setIsDeleting(false) | ||
|
|
Contributor
There was a problem hiding this comment.
This would be better in the slice - enhanced ticket created #2848
| onClick={ (e) => { | ||
| setIsDeleting(true) | ||
| removeWithConfirmation(id, () => { | ||
| dispatch( |
Contributor
There was a problem hiding this comment.
here again it would be better if we can do this in enhanced slice
| loading={ isLoading } | ||
| onClick={ (e) => { | ||
| deleteUser(id, label, onFinish) | ||
| deleteUser(id, label, () => { |
Contributor
There was a problem hiding this comment.
try to invalidate via enhanced file :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #1464
Improved by pimcore/studio-backend-bundle#1637
Additional info
This pull request introduces a new dynamic grid cell type for displaying element subtype icons, refactors email log components for improved prop usage, and enhances GDPR data extractor tables with new icon columns and tooltip support on action buttons. It also adds new tag types and improves tag handling for GDPR-related data.
Dynamic grid cell improvements:
element-subtype-icon, including its component (ElementSubtypeIconCell) and registration in the grid cell registry, allowing tables to visually represent element subtypes with appropriate icons. [1] [2] [3] [4] [5] [6] [7]element-subtype-iconcolumn, providing users with clear visual cues for element types. [1] [2]GDPR data and tag handling:
GDPR_DATAandGDPR_DATA_DETAIL, enabling more granular cache invalidation and data management for GDPR-related features. [1] [2] [3]UI/UX enhancements:
IconButtoncomponent to accept an optional tooltip, and updated action buttons (Export, Open, Delete) in the GDPR data extractor to display tooltips for improved usability. [1] [2] [3] [4] [5]Email log component refactoring:
EmailPreviewandParametersTabcomponents to accept only theidprop instead of the full email object, simplifying component interfaces and usage across the email log module. [1] [2] [3] [4]