tests: raise updater coverage from 68.8% to 86.6%#1
Merged
Conversation
Add coverage-focused tests for previously uncovered branches:
- fetchLatestRelease: non-200, malformed JSON, transport error, UA injection
- checkOnce: fetch error, bad tag, missing daemon, up-to-date, apply error, full apply path
- applyUpdate: missing archive asset, archive download fail, checksum mismatch, corrupt archive
- downloadFile: non-200, unwritable dst, transport error, byte-cap sanity
- VerifyChecksum: missing checksums file, missing archive, blank lines + single-space separator
- replaceBinary: read-only dst dir, overwrite existing
- extractTarGz: read-only dest, truncated tar inside valid gzip
- checkLoop: ticker-fires-then-stop and stop-before-first-tick branches
- signalDaemonRestart{,Linux,Darwin}: smoke-test all three dispatchers
- archiveToInstall mapping pin
Tests use an http.RoundTripper rewriter to redirect the hardcoded
api.github.com URL onto httptest.NewServer — no real network calls.
No production code modified.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_test.gofiles (no production code modified)checkOnce,fetchLatestRelease,applyUpdate,downloadFile,VerifyChecksum,extractTarGz,replaceBinary,checkLoop, and the OS-dispatchedsignalDaemonRestart*helpersapplyUpdate, plus a corrupt-archive-with-valid-hash case)Approach
httptest.NewServer— no calls to github.comfetchLatestReleasehardcodeshttps://api.github.com/..., so tests inject anhttp.RoundTripperthat rewrites scheme+host onto the test server. Lets us drive the fullcheckOncepath without modifying production codet.TempDir()everywhere; race detector cleanCoverage breakdown (after)
checkOncefetchLatestReleasecheckLoopdownloadFilesignalDaemonRestartLinuxapplyUpdateextractTarGzVerifyChecksumTest plan
go test -race -count=1 -timeout 120s ./...passesgo test -cover ./...reports >= 85%Out of scope (iter-1 audit gaps, unchanged)