tests: raise pilot-ca coverage from 60% to 90%#2
Merged
Conversation
Add four new *_test.go files (no production changes): - zz_main_dispatch_test.go: subprocess re-exec via TestMain hijack drives every branch of main() and die() — usage, unknown subcommand, wrong arg counts, happy paths for init-root/issue-beacon/verify, and die-on-error paths for each. main() goes from 0% to 100%, die() from 0% to 100%. - zz_branches_test.go: fills in the remaining error branches in loadRoot (invalid key PEM, key PKCS8 parse failure, cert x509 parse failure) and verifyChain (missing leaf file, root PEM append failure, leaf x509 parse failure). loadRoot 84% to 100%, verifyChain 80% to 95%. - zz_init_root_test.go, zz_load_test.go: small focused branch tests for initRoot/issueBeacon/loadRoot/writePEM/mustMarshalPKCS8 error paths that were previously uncovered. All tests pass under -race -count=1 -timeout 120s and use t.TempDir() with ephemeral keypairs — no real CA root touched.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_test.gofiles (no production code changes) lifting statement coverage from 60.4% → 90.6%.main()anddie()(previously 0%) via aTestMainsubprocess re-exec pattern.loadRoot(84% → 100%) andverifyChain(80% → 95%).go test -race -count=1 -timeout 120s ./....Per-function coverage after
maindieloadRootverifyChaininitRootissueBeaconwritePEMrandomSerialmustMarshalPKCS8The remaining uncovered branches are unreachable without injection (
crypto/randfailures,pem.Encodewrite-to-closed-fd) and not worth the harness complexity.Test plan
go test -race -count=1 -timeout 120s ./...passes locallygo test -coverreports >=85% (actual 90.6%)zz_*_test.gofilest.TempDir(); ephemeral Ed25519/ECDSA keypairs only