Fix: Add @unknown default to WebSocketEvent switch to ensure exhaustive handling#1
Open
isandeepj wants to merge 2 commits intopiesocket:mainfrom
Open
Fix: Add @unknown default to WebSocketEvent switch to ensure exhaustive handling#1isandeepj wants to merge 2 commits intopiesocket:mainfrom
isandeepj wants to merge 2 commits intopiesocket:mainfrom
Conversation
…Socket event cases - Prevents compile-time error when the SDK adds new enum cases - Improves forward compatibility with future PieSocket/Channels SDK updates - Resolves "switch must be exhaustive" error in Channel.swift
Fix: Add @unknown default to WebSocketEvent switch to ensure exhaustive handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes a compiler error related to non-exhaustive switch statements in the WebSocket event handler (likely from Starscream used by PieSocket). It adds an
@unknown defaultcase to future-proof the switch and ensure stability with SDK updates.Changes
@unknown defaultto WebSocketEvent switch block