Skip to content

feat: allow game to be character vector if output is a pdf#41

Merged
trevorld merged 2 commits intomainfrom
issue1
Feb 4, 2026
Merged

feat: allow game to be character vector if output is a pdf#41
trevorld merged 2 commits intomainfrom
issue1

Conversation

@trevorld
Copy link
Member

@trevorld trevorld commented Feb 4, 2026

  • The game argument of save_pamphlet() and save_ruleset() can now be a character vector of games when the target output is a pdf file.
  • save_pamphlet(), save_rulebook(), and save_ruleset() now return the path to the generated file silently.

closes #1

* The `game` argument of `save_pamphlet()`, `save_pocketmod()`, and `save_ruleset()` can now be a character vector of games when the target output is a pdf file.
* `save_pamphlet()`, `save_rulebook()`, and `save_ruleset()` now return the path to the generated file silently.

closes #1
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 95.14563% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (9f96437) to head (21ef0c1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
R/rules.R 95.14% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   86.64%   89.31%   +2.67%     
==========================================
  Files           7        7              
  Lines         599      674      +75     
==========================================
+ Hits          519      602      +83     
+ Misses         80       72       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trevorld trevorld merged commit ab5b2c1 into main Feb 4, 2026
7 checks passed
@trevorld trevorld deleted the issue1 branch February 4, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow "game" to be a character vector for ruleset generation

1 participant