Skip to content

fix(mask-markup): compute mjx-container height based on parent PD-5501 #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlaCostea merged 1 commit into from
Mar 9, 2026
Merged

fix(mask-markup): compute mjx-container height based on parent PD-5501 #2137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions packages/mask-markup/src/components/blank.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,32 @@ function BlankContent({
}
};

const getMeasureNode = () => {
if (!spanRef.current) return null;
const mjx = spanRef.current.querySelector('mjx-container');
if (mjx && spanRef.current.parentElement) return spanRef.current.parentElement;
const img = spanRef.current.querySelector('img');
if (img) return img;
return spanRef.current;
};

const updateDimensions = () => {
if (spanRef.current && rootRef.current) {
// Temporarily set rootRef width to 'auto' for natural measurement
rootRef.current.style.width = 'auto';

// Get the natural dimensions of the content
const width = spanRef.current.offsetWidth || 0;
const height = spanRef.current.offsetHeight || 0;
rootRef.current.style.height = 'auto';
rootRef.current.offsetHeight;

const measureNode = getMeasureNode();
const node = measureNode || spanRef.current;
const rect = node.getBoundingClientRect();
const width = rect.width || node.offsetWidth || 0;
const height = Math.max(
rect.height || 0,
node.offsetHeight || 0,
node.scrollHeight || 0,
spanRef.current.scrollHeight || 0,
);

const widthWithPadding = width + 24; // 12px padding on each side
const heightWithPadding = height + 24; // 12px padding on top and bottom
Expand Down
Loading