Skip to content

fix(rubric): rubricless intructions fix PD-5657 #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlaCostea merged 1 commit into from
Mar 9, 2026
Merged

fix(rubric): rubricless intructions fix PD-5657 #2136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/rubric/src/__tests__/rubric.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ jest.mock('@pie-lib/editable-html-tip-tap', () => {

jest.mock('@pie-lib/config-ui', () => ({
FeedbackConfig: ({ feedback }) => <div data-testid="feedback-config">{JSON.stringify(feedback)}</div>,
InputContainer: ({ children, label }) => (
<div data-testid="input-container" data-label={label}>
{children}
</div>
),
}));

jest.mock('@hello-pangea/dnd', () => ({
Expand Down
38 changes: 22 additions & 16 deletions packages/rubric/src/authoring.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,19 @@ const Container = styled('div')(({ theme }) => ({
padding: theme.spacing(2),
margin: theme.spacing(1),
}));
const InputContainerWrapper = styled('div')(({ theme }) => ({

const StyledInputContainer = styled(InputContainer)(({ theme }) => ({
width: '100%',
paddingTop: theme.spacing(2),
paddingTop: theme.spacing(2.5),
marginBottom: theme.spacing(2),
'& MuiFormControl-root': { width: '100%' },
marginTop: theme.spacing(1),
'& .MuiFormControl-root': { width: '100%' },
'& > .MuiFormLabel-root.MuiInputLabel-shrink': {
fontSize: theme.typography.fontSize + 2,
transform: 'translate(0, 1.5px) scale(0.75)',
},
}));

const Rubricless = styled('div')(() => ({ display: 'none' }));
const ConfigHolder = styled('div')(({ theme }) => ({ paddingTop: theme.spacing(1), paddingBottom: theme.spacing(1) }));
const RubricTitle = styled(Typography)(({ theme }) => ({ paddingLeft: theme.spacing(1), margin: theme.spacing(1) }));
Expand Down Expand Up @@ -301,19 +308,18 @@ export class RawAuthoring extends React.Component {
</FormGroup>

{rubriclessInstructionEnabled && rubricless && (
<InputContainerWrapper>
<InputContainer label={rubriclessInstruction.label}>
<EditableHtml
markup={value.rubriclessInstruction || ''}
onChange={this.changeRubriclessInstruction}
pluginProps={pluginOpts}
nonEmpty={false}
disableUnderline
languageCharactersProps={[{ language: 'spanish' }, { language: 'special' }]}
mathMlOptions={mathMlOptions}
/>
</InputContainer>
</InputContainerWrapper>
<StyledInputContainer label={rubriclessInstruction.label}>
<EditableHtml
markup={value.rubriclessInstruction || ''}
onChange={this.changeRubriclessInstruction}
pluginProps={pluginOpts}
nonEmpty={false}
disableUnderline
languageCharactersProps={[{ language: 'spanish' }, { language: 'special' }]}
mathMlOptions={mathMlOptions}
autoWidthToolbar
/>
</StyledInputContainer>
)}

<div>
Expand Down
Loading