Wpf/WinForms: add text alignment to NumericStepper control#2822
Closed
luke-ransfield wants to merge 3 commits intopicoe:developfrom
Closed
Wpf/WinForms: add text alignment to NumericStepper control#2822luke-ransfield wants to merge 3 commits intopicoe:developfrom
luke-ransfield wants to merge 3 commits intopicoe:developfrom
Conversation
cwensley
added a commit
to cwensley/Eto
that referenced
this pull request
Apr 13, 2026
- Fixes up NumericStepper regressions on WPF (which now uses ThemedNumericStepperHandler) due to removal of XWT. - Added NumericStepper.TextAlignment. Fixes picoe#2822. - Add ability for IMaskedTextProvider to update text after editing vs. during editing to allow more flexibility for free form input for variable providers - Add TextBox.ReadOnlyChanged and OnReadOnlyChanged - Add MinValue/MaxValue/Increment/Wrap/FormatString/MaximumDecimalPlaces/DecimalPlaces to NumericMaskedTextStepper<T> - Add DecimalPlaces/MaximumDecimalPlaces/FormatString to NumericMaskedTextProvider
Member
|
Hey @luke-ransfield, Thanks so much for submitting this PR. I've added the NumericStepper.TextAlignment property in #2930 and tested on all platforms to ensure consistent/correct behaviour. Cheers! |
cwensley
added a commit
to cwensley/Eto
that referenced
this pull request
Apr 13, 2026
- Fixes up NumericStepper regressions on WPF (which now uses ThemedNumericStepperHandler) due to removal of XWT. - Added NumericStepper.TextAlignment. Fixes picoe#2822. - Add ability for IMaskedTextProvider to update text after editing vs. during editing to allow more flexibility for free form input for variable providers - Add TextBox.ReadOnlyChanged and OnReadOnlyChanged - Add MinValue/MaxValue/Increment/Wrap/FormatString/MaximumDecimalPlaces/DecimalPlaces to NumericMaskedTextStepper<T> - Add DecimalPlaces/MaximumDecimalPlaces/FormatString to NumericMaskedTextProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds text alignment to the NumericStepper control for WPF/WinForms. Also added examples of NumericStepper for each alignment to the Eto.Test App:
Have set the default alignment to
TextAlignment.Leftto keep it consistent with existing behavior.Have made changes for Gtk but haven't tested.