Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 87.34% 87.26% -0.08%
==========================================
Files 52 52
Lines 6510 6527 +17
Branches 730 732 +2
==========================================
+ Hits 5686 5696 +10
- Misses 802 809 +7
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens FirstOrderDynamics against std::out_of_range exceptions by replacing .at() lookups with .find() checks and handling missing entries via logging + early return/std::nullopt.
Changes:
- Guard itinerary lookup in
m_addAgentsODs()and skip insertion when the destination itinerary is missing. - Adjust OD selection logic to ensure an OD is always selected (fallback to last element) instead of relying on strict floating-point comparisons.
- Guard itinerary path lookup in
m_nextStreetId()and returnstd::nulloptwhen no path entry exists for the current node.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.