Skip to content

Dump coilcode with network info#435

Merged
Grufoony merged 2 commits intomainfrom
dumpcoilcode
Apr 9, 2026
Merged

Dump coilcode with network info#435
Grufoony merged 2 commits intomainfrom
dumpcoilcode

Conversation

@Grufoony
Copy link
Copy Markdown
Collaborator

@Grufoony Grufoony commented Apr 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 9, 2026 14:55
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.33%. Comparing base (50f6cd4) to head (2e4e4a9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   87.32%   87.33%           
=======================================
  Files          52       52           
  Lines        6516     6520    +4     
  Branches      728      731    +3     
=======================================
+ Hits         5690     5694    +4     
  Misses        804      804           
  Partials       22       22           
Flag Coverage Δ
unittests 87.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the dumped road-network metadata by adding a coilcode field to the edges table in the simulation SQLite DB, and updates the web viewer to read that field. It also bumps the DSF patch version and updates release metadata.

Changes:

  • Add coilcode column to the edges table schema and populate it from each street’s counter name when dumping the network.
  • Update the webapp’s edge loader query to fetch coilcode and attach it to loaded edge objects.
  • Bump version metadata (DSF version + CITATION.cff).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
webapp/script.js Reads coilcode from edges and attaches it to edge objects loaded from the SQLite DB.
src/dsf/mobility/FirstOrderDynamics.cpp Adds coilcode column to edges schema and inserts per-edge coil identifier when dumping the network.
src/dsf/dsf.hpp Patch version bump from 5.3.2 to 5.3.3.
CITATION.cff Updates version/date-released to match the new patch release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Grufoony Grufoony merged commit b49bf11 into main Apr 9, 2026
53 checks passed
@Grufoony Grufoony deleted the dumpcoilcode branch April 9, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants