Skip to content

Avoid false error on is_subclass_of #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
VincentLanglet wants to merge 4 commits into
base: 2.1.x
Choose a base branch
from
Open

Avoid false error on is_subclass_of #4472

VincentLanglet wants to merge 4 commits into from
+121 −24

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Oct 23, 2025 •
edited
Loading

@VincentLanglet VincentLanglet mentioned this pull request Oct 23, 2025
Open
@VincentLanglet VincentLanglet force-pushed the isSubClass branch 2 times, most recently from 5500473 to 8576d53 Compare October 24, 2025 17:19
VincentLanglet
VincentLanglet commented Oct 24, 2025
View reviewed changes
@VincentLanglet VincentLanglet marked this pull request as ready for review October 24, 2025 17:33
@phpstan-bot
Copy link
Collaborator

phpstan-bot commented Oct 24, 2025

This pull request has been marked as ready for review.

VincentLanglet
VincentLanglet commented Oct 24, 2025
View reviewed changes
@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Oct 24, 2025

This issue was more complicated than expected... I'm not against your opinion/review @staabm :)

staabm
staabm reviewed Oct 29, 2025
View reviewed changes
@VincentLanglet VincentLanglet requested a review from staabm October 29, 2025 21:49
staabm
staabm reviewed Oct 30, 2025
View reviewed changes
tests/PHPStan/Analyser/nsrt/is-subclass-of.php
namespace IsSubclassOf;

function (Bar $a, Bar $b, Bar $c, Bar $d) {
if (is_subclass_of($a, Bar::class)) {
Copy link
Contributor

@staabm staabm Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test somewhere for use of is_subclass_of with a final-class ?

Copy link
Contributor Author

@VincentLanglet VincentLanglet Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@VincentLanglet VincentLanglet requested a review from staabm October 31, 2025 15:32
@VincentLanglet VincentLanglet force-pushed the isSubClass branch 2 times, most recently from 5aab962 to b37f439 Compare December 5, 2025 15:28
@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Dec 5, 2025

I dunno what to do about the webmozart-assert failure because I don't report anymore

Call to static method Webmozart\Assert\Assert::implementsInterface() with class-string<WebmozartAssertImpossibleCheck\Bar>|WebmozartAssertImpossibleCheck\Bar and 'WebmozartAssertImpossibleCheck\\Bar' will always evaluate to true.

Technically, because a implementsInterface check is called before it's indeed always true.
But strictly looking at the type, calling

class-string<WebmozartAssertImpossibleCheck\Bar>|WebmozartAssertImpossibleCheck\Bar

And currently, phpstan/phpstan-webmozart-assert#194 is showing the issue

@VincentLanglet VincentLanglet mentioned this pull request Dec 5, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staabm staabm Awaiting requested review from staabm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHPStan incorrectly narrows type of object after an instanceof check

3 participants

@VincentLanglet @phpstan-bot @staabm