Fix #283 - MariaDB window function with alias gives bad linting errors

[niconoe-]

Fixes #283

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (88c8314) 97.02% compared to head (bf03484) 97.02%.

Additional details and impacted files

@@            Coverage Diff            @@
##              5.8.x     #487   +/-   ##
=========================================
  Coverage     97.02%   97.02%           
- Complexity     2234     2235    +1     
=========================================
  Files            69       69           
  Lines          5144     5145    +1     
=========================================
+ Hits           4991     4992    +1     
  Misses          153      153           

Impacted Files	Coverage Δ
src/Components/ArrayObj.php	100.00% <ø> (ø)
src/Components/IndexHint.php	100.00% <ø> (ø)
src/Components/Expression.php	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[niconoe-]

The issue was that both "AS" and "OVER" are of type "NONE", so we were entering in the alias handling too early. The "OVER" was considered as the alias part, so when the "AS" comes out, the parser wrongly interpreted it as a second alias, and failed.

With this quickfix, I force the parser to disallow "OVER" as an alias-setting keyword, so that the whole windowing process in included in the expression, and "AS" is correctly recognized as the first (and only) alias-setting keyword.

Commits are showing the difference of the tokens management, by comparing before and after.

@williamdes This time, I picked up the right branch when I created the PR, and the tests are passing 😉

[williamdes]

Looks okay, thank you !