Skip to content

Fix 8.4 implicit null callable #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fey wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −4
Open

Fix 8.4 implicit null callable #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b6327
fix Implicitly marking parameter $callback as nullable is deprecated
fey Jun 26, 2025
161ee20
Add 8.2, 8.3, 8.4 to travis ci
fey Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ php:
- 5.5
- 5.6
- 7.0
- 8.2
- 8.3
- 8.4
- hhvm

before_install:
Expand Down
8 changes: 4 additions & 4 deletions src/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ function countBy($collection, $callback)
* @author Aurimas Niekis <aurimas@niekis.lt>
*
* @param array $collection
* @param callable $callback
* @param callable|null $callback
*
* @return bool
*/
function every($collection, callable $callback = null)
function every($collection, ?callable $callback = null)
{
if (null === $callback) {
$callback = function ($item) use ($callback) {
Expand Down Expand Up @@ -514,11 +514,11 @@ function size($collection, $countRecursive = false)
* @author Aurimas Niekis <aurimas@niekis.lt>
*
* @param array $collection
* @param callable $callback
* @param callable|null $callback
*
* @return bool
*/
function some($collection, callable $callback = null)
function some($collection, ?callable $callback = null)
{
if (null === $callback) {
$callback = function ($item) use ($callback) {
Expand Down