(Docs) CSS stylesheets: Fix for PHP 8.3+ highlight_string changes#1525
Closed
AllenJB wants to merge 1 commit intophp:masterfrom
Closed
(Docs) CSS stylesheets: Fix for PHP 8.3+ highlight_string changes#1525AllenJB wants to merge 1 commit intophp:masterfrom
AllenJB wants to merge 1 commit intophp:masterfrom
Conversation
AllenJB
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
Author
|
Duplicate of #1501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: php/phd#208
When generating docs with PHP 8.3+, the examples have lost the padding due to changes in the code generated by highlight_string.
This currently only affects users generating their own docs, but will affect the web docs when the PHP version used to generate those is updated.
I tested these changes locally and with the current live web docs (using stylish) and did not find anywhere it interfered with the current styles.