Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Test the Action
on:
push:
pull_request:

env:
RELEASE_TAG: 0.0.0-fake+run_${{ github.run_id }}_${{ github.run_attempt }}
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ with:

| Name | Description |
|----------------|-----------------------------------|
| `package-path` | Path to the generated `.tgz` file |
| `package-path` | Path to the generated `.zip` file |

## Complete example

Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
# the given tag name
- name: Build and release
id: php-ext-binary-builder
uses: php/pie-ext-binary-builder@0.0.1
uses: php/pie-ext-binary-builder@0.0.2
with:
release-tag: ${{ github.ref_name }}
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ inputs:
required: true
outputs:
package-path:
description: 'Path to the generated .tgz package'
description: 'Path to the generated .zip package'
runs:
using: 'node20'
main: dist/index.js
4 changes: 2 additions & 2 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -32303,13 +32303,13 @@ async function uploadReleaseAsset(releaseTag, packageFilename) {
const zendDebug = await determinePhpDebugMode(phpBinary);
const ztsMode = await determineZendThreadSafeMode(phpBinary);
const extSoFile = `${extName}.so`;
const extPackageName = `php_${extName}-${releaseTag}_php${phpMajorMinor}-${arch}-${os}-${libcFlavour}${zendDebug}${ztsMode}.tgz`;
const extPackageName = `php_${extName}-${releaseTag}_php${phpMajorMinor}-${arch}-${os}-${libcFlavour}${zendDebug}${ztsMode}.zip`;

await buildExtension();

await exec.exec("ls", ["-l", "modules"]);

await exec.exec(`tar -cvzf ${extPackageName} -C modules ${extSoFile}`);
await exec.exec(`zip -j ${extPackageName} modules/${extSoFile}`);

await uploadReleaseAsset(releaseTag, extPackageName);

Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,13 @@ async function uploadReleaseAsset(releaseTag, packageFilename) {
const zendDebug = await determinePhpDebugMode(phpBinary);
const ztsMode = await determineZendThreadSafeMode(phpBinary);
const extSoFile = `${extName}.so`;
const extPackageName = `php_${extName}-${releaseTag}_php${phpMajorMinor}-${arch}-${os}-${libcFlavour}${zendDebug}${ztsMode}.tgz`;
const extPackageName = `php_${extName}-${releaseTag}_php${phpMajorMinor}-${arch}-${os}-${libcFlavour}${zendDebug}${ztsMode}.zip`;

await buildExtension();

await exec.exec("ls", ["-l", "modules"]);

await exec.exec(`tar -cvzf ${extPackageName} -C modules ${extSoFile}`);
await exec.exec(`zip -j ${extPackageName} modules/${extSoFile}`);

await uploadReleaseAsset(releaseTag, extPackageName);

Expand Down