zend_types: Convert Z_*REF*_P() macros into inline functions#22300
Open
TimWolla wants to merge 1 commit into
Open
zend_types: Convert Z_*REF*_P() macros into inline functions#22300TimWolla wants to merge 1 commit into
Z_*REF*_P() macros into inline functions#22300TimWolla wants to merge 1 commit into
Conversation
bwoebi
reviewed
Jun 14, 2026
| #endif | ||
| return GC_REFCOUNT(Z_COUNTED_P(pz)); | ||
| } | ||
| static zend_always_inline uint32_t Z_REFCOUNT_P(const zval *z) { return zval_refcount_p(z); } |
Member
There was a problem hiding this comment.
I don't think it's worth creating inline functions for pure aliases - the type is anyway forwarded directly.
This is sort of just odd to me...
Member
There was a problem hiding this comment.
the try_addref_p/try_delref_p ones are fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.