std/dba: validate file permission argument in dba_open()#22228
Open
arshidkv12 wants to merge 2 commits into
Open
std/dba: validate file permission argument in dba_open()#22228arshidkv12 wants to merge 2 commits into
arshidkv12 wants to merge 2 commits into
Conversation
Girgias
reviewed
Jun 14, 2026
Comment on lines
+566
to
+569
| if (permission < 0 || (permission & ~07777) != 0) { | ||
| zend_argument_value_error(4, "Invalid file permission value (must be between 0 and 07777)"); | ||
| RETURN_THROWS(); | ||
| } |
Member
There was a problem hiding this comment.
I think it would be good to have some sort of global API for this, as many INI settings also should be checking valid permissions, and do all of those changes in one single PR rather than scattered around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.