Closed
Conversation
pcntl_alarm() accepts a zend_long (signed) but passes it to alarm(), which takes an unsigned int. Negative values silently wrap to large unsigned values, scheduling an alarm far in the future instead of raising an error.
deduplicated max signals computation by using globals
since it is casted to zend_long, better using add_assoc_long_ex due to loss of precision with add_assoc_double_ex
Girgias
approved these changes
Feb 26, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Makes sense to me, only a small question regarding 0
|
|
||
| if (seconds < 0) { | ||
| zend_argument_value_error(1, "must be greater or equal to 0"); | ||
| if (seconds < 0 || seconds > UINT_MAX) { |
Member
There was a problem hiding this comment.
Can you really provide a value of 0?
Member
Author
There was a problem hiding this comment.
yes 0 means disabling any pending alarm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.