Audit zend_ini_string() and related functions

[Girgias]

Conflicts with #21143

I audited the usage of zend_ini_string() and co as I believe these functions should return a const char* because they point to a pointer owner by a zend_string *.

The two other things I am wondering is

• if we should remove the INI_STR() macro as it doesn't follow the usual convention of "string" being a char* and "str" meaning a zend_string*.
• if we should remove the INI_ORIG_* macros as they seem mostly pointless?

[arnaud-lb]

Looks good to me.

One caveat with ZEND_STRL() is that it would break if the outer function call was turned into a macro, as it is seen as a single argument during expansion.

An alternative to removing INI_STR(), that would also eliminate the need for ZEND_STRL(), would be to introduce _literal variants of zend_ini_str(ing)(_ex), like we have in the string API, and then remove or deprecate INI_STR(). But then we might want to also add _literal variants of the other zend_ini_ functions to replace all INI_ macros. No strong opinion on this.

[Girgias]

Looks good to me.

One caveat with ZEND_STRL() is that it would break if the outer function call was turned into a macro, as it is seen as a single argument during expansion.

An alternative to removing INI_STR(), that would also eliminate the need for ZEND_STRL(), would be to introduce _literal variants of zend_ini_str(ing)(_ex), like we have in the string API, and then remove or deprecate INI_STR(). But then we might want to also add _literal variants of the other zend_ini_ functions to replace all INI_ macros. No strong opinion on this.

I quite like the idea of using a new literal API variant, will do this and check what the usage of thoses macros are with sourcegraph to see if it is reasonable to remove them outright or not.