Fix GH-18223: Meaningful error on wrong trait method exclusion#19404
Open
alexandre-daubois wants to merge 1 commit intophp:PHP-8.4from
Open
Fix GH-18223: Meaningful error on wrong trait method exclusion#19404alexandre-daubois wants to merge 1 commit intophp:PHP-8.4from
alexandre-daubois wants to merge 1 commit intophp:PHP-8.4from
Conversation
alexandre-daubois
force-pushed
the
traits-precedence
branch
from
d1a6e37 to
5eb7a5a
Compare
alexandre-daubois
force-pushed
the
traits-precedence
branch
from
5eb7a5a to
3a12569
Compare
alexandre-daubois
force-pushed
the
traits-precedence
branch
from
3a12569 to
e55098e
Compare
Member
Author
|
Friendly ping @iluuu1994 as you wrote the issue 🙂 |
alexandre-daubois
force-pushed
the
traits-precedence
branch
from
e55098e to
9fb9353
Compare
alexandre-daubois
force-pushed
the
traits-precedence
branch
from
9fb9353 to
2a1ee81
Compare
Member
|
@alexandre-daubois I'll try to have a look tomorrow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18223
This adds a compile-time validation to detect invalid trait insteadof rules that would exclude all method implementations. This replaces the confusing runtime "undefined method" errors with a meaningful message.