Docs: document intval() behavior with scientific notation#5100
Closed
anshujain0 wants to merge 2 commits intophp:masterfrom
Closed
Docs: document intval() behavior with scientific notation#5100anshujain0 wants to merge 2 commits intophp:masterfrom
anshujain0 wants to merge 2 commits intophp:masterfrom
Conversation
Member
|
Conflicts with #5098 |
Author
|
Thanks for pointing this out, and sorry for the duplicate PR. I missed the existing PR (#5098) when I opened this one. After reviewing it, I agree that it already covers the same change, so I’ve closed this PR to avoid duplication. Appreciate the review and guidance. I’ll make sure to double-check for existing PRs more carefully before opening new ones in the future. |
Member
|
Not your fault, GitHub does a bad job at automatically linking PRs with issues unless manually done, which is easy to forget :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a documentation note explaining how intval() behaves when
converting strings containing scientific notation, including cases where
integer overflow results in PHP_INT_MAX.
Fixes #5019